Closes #26 by adding support for PDF reports#27
Merged
scottbrown merged 1 commit intomainfrom May 7, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for generating PDF reports, addressing issue #26. Key changes include:
- Introducing PDF report generation in both overall and category contexts.
- Updating tests in report_test.go to validate PDF report content and header.
- Modifying command flags and report command logic to handle the new PDF format and adding the required gofpdf dependency.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| report_test.go | Added tests for PDF report generation and refactored report output. |
| go.mod | Added the gofpdf dependency to support PDF generation. |
| cmd/flag.go | Updated flag help to include "pdf" as a valid report format. |
| cmd/cmd_report.go | Modified report generation and output handling to accommodate PDF. |
Comment on lines
+423
to
+424
| if len(pdfReport.Content) < 4 || string(pdfReport.Content[:4]) != "%PDF" { | ||
| t.Error("Expected PDF content to start with '%PDF'") |
There was a problem hiding this comment.
[nitpick] Consider extracting the PDF header '%PDF' into a constant to improve code clarity and maintainability.
Suggested change
| if len(pdfReport.Content) < 4 || string(pdfReport.Content[:4]) != "%PDF" { | |
| t.Error("Expected PDF content to start with '%PDF'") | |
| if len(pdfReport.Content) < 4 || string(pdfReport.Content[:4]) != PDFHeader { | |
| t.Errorf("Expected PDF content to start with '%s'", PDFHeader) |
Comment on lines
+444
to
+445
| if len(categoryPDFReport.Content) < 4 || string(categoryPDFReport.Content[:4]) != "%PDF" { | ||
| t.Error("Expected PDF content to start with '%PDF'") |
There was a problem hiding this comment.
[nitpick] Consider extracting the PDF header '%PDF' into a constant to improve clarity in the category PDF tests as well.
Suggested change
| if len(categoryPDFReport.Content) < 4 || string(categoryPDFReport.Content[:4]) != "%PDF" { | |
| t.Error("Expected PDF content to start with '%PDF'") | |
| if len(categoryPDFReport.Content) < 4 || string(categoryPDFReport.Content[:4]) != PDFHeader { | |
| t.Errorf("Expected PDF content to start with '%s'", PDFHeader) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.