[ENHANCEMENT] NeuralAmpModelerCore v0.4.0.rc1 #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to C++20 - Update C++ standard to C++20 in common-win.props and common-mac.xcconfig (required by NeuralAmpModelerCore dependency) - Add missing NAM source/header files to Visual Studio projects: - conv1d.cpp/h, ring_buffer.cpp/h - film.h, gating_activations.h, registry.h (header-only) - Updated: vst3, app, aax projects - Add missing files to macOS Xcode project: - film.h, gating_activations.h, registry.h (header-only) - Add missing files to iOS Xcode project: - conv1d.cpp/h, ring_buffer.cpp/h - film.h, gating_activations.h, registry.h (header-only) All new files from NeuralAmpModelerCore are now properly included in build configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates NeuralAmpModelerCore to v0.4.0.rc1.
Builders looking to upgrade from v0.3.0 to 0.4.0 can consult this to see what high-level changes to expect to do. The main one is the change to multi-input, multi-output models. The other is that there are new source & header files to track.
With this PR, the plugin should (fingers crossed) be able to support Architecture A2 at full size; slimmability is still to come.