Strings to enums

[tkanakamalla]

Fixes #1

• enums
• rtpmap
• fmtp
• rtcp
• rtcp-fb
• extmap
• fingerprint
• group
• candidate
• crypto
• ssrc
• setup
• direction
• squash/fixup the commits as required

[sdroege]

Otherwise looks good to me

[sdroege]

clippy should be clean if you rebase on top of latest main

[sdroege]

Potentially useful, just like for the registered payload types. But in this struct here, a string / u8 is the correct thing. You could have functions on the struct that try to handle pt / encoding with those enums though

[sdroege]

https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/blob/44a632811e6718909409b5c229508072a1447e62/net/rtsp/src/rtspsrc/sdp.rs#L215 basically having guess_rtpmap_from_pt() and guess_rtpmap_from_encoding_name() here in some form seems useful.

@nirbheek Do you remember why your code allows rtpmap without clock-rate? The SDP RFC does not allow that

[nirbheek]

There are payload types for which clock-rate is static, and tools like ffmpeg won't add the clock-rate in those cases. For example pt=10/11 (L16 2ch/1ch), see table in https://en.wikipedia.org/wiki/RTP_payload_formats#Audio_and_video_payload_types.

[sdroege]

Thanks. ffmpeg is wrong to not add it of course, specifying the clock rate in the SDP is not optional.

[tkanakamalla]

   Compiling sdp-types v0.1.8 (/home/runner/work/sdp-types/sdp-types)
error[E0106]: missing lifetime specifier
   --> src/lib.rs:363:17
    |
363 |     const NAME: &str;
    |                 ^ expected named lifetime parameter
    |
help: consider introducing a named lifetime parameter
    |
362 ~ pub trait TypedAttribute<'a>: Display + FromStr<Err = AttributeErr> {
363 ~     const NAME: &'a str;
    |

I wonder why the other tests or my local build did not report this error

[sdroege]

I wonder why the other tests or my local build did not report this error

Because you don't build with Rust 1.65

[tkanakamalla]

So is it a shortcoming of Rust 1.65? Why do we have a test with that specific version?

[sdroege]

Because that's the minimum version supported here

[sdroege]

This one should probably also be updated accordingly. Note that this is not just a single address but can include a multicast TTL or a "number of addresses".

[sdroege]

(and the other fields, nettype/addrtype are like what you handle elsewhere here already)

[tkanakamalla]

Did you mean changing the types of these? We want to keep backward compatibility, so added the try-get and set-from methods for these.

[sdroege]

Yes, methods like that

[tkanakamalla]

Yeah those are already added in impl Connection 21c47b5#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R650