Feat: implement hnsw index #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arshdeep54
force-pushed
the
hnsw-index
branch
5 times, most recently
from
e160cf5 to
3a275c3
Compare
Arshdeep54
added a commit
to Arshdeep54/indexium
that referenced
this pull request
Dec 21, 2025
HNSW implementation code from my PR on sdslabs/VortexDB sdslabs/VortexDB#43 Signed-off-by: Arshdeep54 <balarsh535@gmail.com>
Arshdeep54
force-pushed
the
hnsw-index
branch
2 times, most recently
from
1d98363 to
f883ad4
Compare
Signed-off-by: Arshdeep54 <balarsh535@gmail.com>
Arshdeep54
force-pushed
the
hnsw-index
branch
from
f883ad4 to
9f8ca6d
Compare
4adex
requested changes
Jan 13, 2026
| // Per-node, per-level neighbor lists (bounded by M/M0) | ||
| pub nodes: HashMap<PointId, Node>, | ||
| // Number of points inserted | ||
| pub nb_point: usize, |
Collaborator
There was a problem hiding this comment.
nb_point is never utilized or updated
| // Cached dimension of stored vectors | ||
| pub data_dimension: Dimension, | ||
| // Guard against concurrent mutation during queries | ||
| pub searching: bool, |
Collaborator
There was a problem hiding this comment.
this flag is never utilized?
| let mut current = ep; | ||
| loop { | ||
| let cur_vec = self.get_vec(current); | ||
| let mut best_score = distance(query.to_vec(), cur_vec.to_vec(), self.similarity); |
Collaborator
There was a problem hiding this comment.
need to change distance function to take references instead of copies, otherwise it will be slower. I changed distance function accordingly in KD Tree PR, please check that.
| /// - greedy descend from current entry to l+1 to get a pivot | ||
| /// - for each level down to 0: ef-construction, diversity pruning, bidirectional connect with caps | ||
| /// - if l is above current max level, update the entry point | ||
| fn insert(&mut self, vector: IndexedVector) -> Result<(), DbError> { |
Collaborator
There was a problem hiding this comment.
add a check that a point with same id does not exist already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HNSW implementation referenced from HNSW (Malkov & Yashunin)
Includes the following public functions :