Skip to content

Conversation

@frances-h
Copy link
Contributor

Resolve #2768

@frances-h frances-h self-assigned this Jan 5, 2026
@frances-h frances-h requested a review from a team as a code owner January 5, 2026 16:11
@frances-h frances-h requested review from R-Palazzo and amontanez24 and removed request for a team January 5, 2026 16:11
@frances-h frances-h force-pushed the issue-2768-AttributeError-col-relationships-with-constraints branch from 8e204d5 to 44a3ffd Compare January 5, 2026 16:15
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (4c16f9d) to head (44a3ffd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2771   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          73       73           
  Lines        8078     8079    +1     
=======================================
+ Hits         7927     7928    +1     
  Misses        151      151           
Flag Coverage Δ
integration 75.59% <100.00%> (+0.02%) ⬆️
unit 97.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

except ConstraintNotMetError:
raise e

self.metadata.validate()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data processor uses the _valid_column_relationships attribute here to iterate over column relationships. That attribute only gets set here when validating the column relationships.

When we add constraints at the single table level, we use the updated metadata from the constraints for the data processor, but it was missing the _valid_column_relationships attribute because the updated metadata hadn't been validated.

@frances-h frances-h merged commit 7ff0afa into main Jan 7, 2026
41 checks passed
@frances-h frances-h deleted the issue-2768-AttributeError-col-relationships-with-constraints branch January 7, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combining column relationship with constraints not working

4 participants