tool: emit empty strtab when serialising ELF #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamliner787-9
force-pushed
the
elf_fix
branch
from
860eace to
3535498
Compare
Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
dreamliner787-9
force-pushed
the
elf_fix
branch
from
3535498 to
446ef8f
Compare
dreamliner787-9
force-pushed
the
elf_fix
branch
from
e5e412a to
446ef8f
Compare
| // data_off_watermark += 1; | ||
| // Have to comment out to keep clippy happy, else: | ||
| // "warning: value assigned to `data_off_watermark` is never read", or if we try to allow with `#[allow(unused_assignments)]`: | ||
| // "error[E0658]: attributes on expressions are experimental" |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
or just remove these commented lines entirely?
Collaborator
|
I was able to get the objcopy working with the segment having zero size so maybe we should just remove the fake data part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit an empty strtab when serialising ELF. To fix this issue when converting the tool outputted ELF back into a binary: