Skip to content

Rename url to Url #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piecubed wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename url to Url #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions totp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ func (otp *Totp) Secret() string {

// URL returns a suitable URL, such as for the Google Authenticator app
// example: otpauth://totp/Example:alice@google.com?secret=JBSWY3DPEHPK3PXP&issuer=Example
func (otp *Totp) url() (string, error) {
func (otp *Totp) Url() (string, error) {

// verify the proper initialization
if err := totpHasBeenInitialized(otp); err != nil {
Expand Down Expand Up @@ -322,7 +322,7 @@ func (otp *Totp) url() (string, error) {
func (otp *Totp) QR() ([]byte, error) {

// get the URL
u, err := otp.url()
u, err := otp.Url()

// check for errors during initialization
// this is already done on the URL method
Expand Down
6 changes: 3 additions & 3 deletions totp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,12 +308,12 @@ func TestSerialization(t *testing.T) {
t.Error("Deserialized hash property differ from original TOTP")
}

deserializedUrl, err := deserializedOTP.url()
deserializedUrl, err := deserializedOTP.Url()
if err != nil {
t.Error(err)
}

otpdUrl, err := otp.url()
otpdUrl, err := otp.Url()
if err != nil {
t.Error(err)
}
Expand Down Expand Up @@ -342,7 +342,7 @@ func TestSerialization(t *testing.T) {

func TestProperInitialization(t *testing.T) {
otp := Totp{}
if _, err := otp.url(); err == nil {
if _, err := otp.Url(); err == nil {
t.Fatal("Totp is not properly initialized and the method did not catch it")
}
}
Expand Down