Open
Conversation
Member
|
Thanks. Can you also add a test case in GitHub Actions? 🙏 |
Author
|
Okay will do that |
Member
|
flows summarize |
Member
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. There are potential security issues with the Redis connection in the implementation, and there are no tests or documentation added for the Redis functionality. The purpose of the Redis example is not clear, and the implementation could benefit from improved data structures for the use case. There are also unused dependencies and no tests included. These issues need to be addressed before the pull request can be merged. DetailsCommit 5c745acc26b238a0e6e46a3d07f0c6de44396993Key changes:
Potential problems:
Commit db2be299769dee9ef76f7aa9699a773cf4edb6e8Key Changes:
Potential Problems:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a Redis as a new datasource to the framework. I have added its support to the main library as well as added an example.