-
Notifications
You must be signed in to change notification settings - Fork 72
repo-sync-2026-02-09 #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
repo-sync-2026-02-09 #779
Conversation
Summary of ChangesHello @fucangfy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a substantial architectural evolution of the SCQL project. It streamlines the codebase by removing several legacy components and their supporting infrastructure, focusing on a leaner core. The introduction of a new compiler API version signifies a forward-looking approach to how SQL queries are processed and secured within the system. These changes collectively aim to modernize the project's foundation, improve maintainability, and prepare for future feature development. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on refactoring the project structure, updating Bazel dependencies, and modifying CI/CD configurations. Key changes include removing the contrib directory from Go test scopes and Bazel path filtering, updating Bazel module versions for yacl, psi, spulib, dataproxy_sdk_cc, arrow, openssl, and adding perfetto and pybind11_bazel dependencies. The .bazelrc file was updated to include remote download outputs and proto descriptor sets, and ASAN options. The api directory saw significant changes with the removal of broker.proto, ccl.proto, and scdb_api.proto, and the introduction of scql_task.proto and compiler.proto (under v1alpha1), along with new buf_lint_test rules for proto files. The core.proto file was updated to include DECIMAL as a primitive data type and changed aliases for INT, INTEGER, and FLOAT to point to 64-bit types, which is a significant breaking change. The engine.proto now includes StreamingOptions, PsiOptions, and NegotiationOptions. The datasource directory in the engine was refactored to introduce datamesh adaptors and factories, replacing previous dataproxy implementations, and enhancing CSVDB datasource merging. The main.cc in engine/exe was updated to support a new kpad task mode. Additionally, various documentation files (CONTRIBUTING.md, LEGAL.md, README.md, REPO_LAYOUT.md) and configuration files (.gitignore, .golangci.yml, .licenserc.yaml, .vscode/*, Makefile) were updated to reflect these structural and dependency changes, including removing references to scdb components and updating linting rules.
No description provided.