Add ADO support and ADO git URL handling#960
Conversation
| return { | ||
| host: url.resource, | ||
| repository: url.full_name, | ||
| repository: repository, |
There was a problem hiding this comment.
| repository: repository, | |
| repository: `${url.owner}/${url.repo}`, |
Rather than doing this manually this seems more stable
https://github.com/IonicaBizau/git-url-parse/blob/master/test/index.js
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@secustor/backstage-plugin-renovate-backend': patch | |||
There was a problem hiding this comment.
| '@secustor/backstage-plugin-renovate-backend': patch | |
| '@secustor/backstage-plugin-renovate-backend': minor |
Also split up these changesets please
There was a problem hiding this comment.
Apologies, not too familiar with changesets. Yeah, I can break them up into one for each package.
| token: ${GITHUB_TOKEN} | ||
| azure: | ||
| - host: dev.azure.com | ||
| token: ${AZURE_PAT_TOKEN} |
There was a problem hiding this comment.
This is not correct based on the docs.
https://backstage.io/docs/integrations/azure/locations#using-a-personal-access-token-pat
There was a problem hiding this comment.
You are correct, it is a deprecated method though still currently working. The way listed in the docs is the updated way though I wasn't sure if more changes would've been needed if I did the one listed in their docs. I can test and find out though. If it isn't a huge hassle, I'll update it to use the documented version shortly.
There was a problem hiding this comment.
Yeah, please update to the upstream documented style
2 participants
Adds ADO and adds handling its odd repo structure.
This PR provides the actual support needed for ADO to be found with git due to how ADO urls work. Otherwise simple-git will fail the URL passed by the backend.
ADO git urls look something like dev.azure.com/org/project/_git/repo or org.visualstudio.com/project/_git/repo
I've went ahead and merged in the changes from the other PR and added the needed ones to actually run against ADO in this one.