Update Firebase SDK to v12.1.0 and dependencies#32
Update Firebase SDK to v12.1.0 and dependencies#32rickpasveer wants to merge 4 commits intosegment-integrations:mainfrom
Conversation
- Bump Firebase iOS SDK from 11.1.0 to 12.1.0 - Update analytics-swift from 1.4.7 to 1.8.0 - Update GoogleUtilities from 8.0.2 to 8.1.0 - Update related Firebase and Google dependencies to latest versions
* removed due to shutdown of service
|
Please consider merging this PR. Currently, Segment makes it impossible to use the current version of Firebase, creating all sorts of dependency issues with libraries that keep up-to-date on Firebase's major. A well-maintained library should always support the current stable major of its dependencies. |
If you need immediate resolution of things, feel free to reach out to your segment rep or fork the repo. No need to lecture on what a well-maintained library should be like. I have a team of 5 people, 60 libraries to maintain and 253 destinations to look after. I'm sure you can sympathize. |
Package.swift
Outdated
| @@ -1,15 +1,15 @@ | |||
| // swift-tools-version:5.3 | |||
| // swift-tools-version:6.0 | |||
There was a problem hiding this comment.
I don't see that 6.0 has made it to https://github.com/swiftlang/swift-package-manager/tree/main/Documentation/ReleaseNotes yet. Not sure why.
Presumably this is just a "bump to latest", I don't see any change that should benefit from or necessitate it.
There was a problem hiding this comment.
I've lowered the package swift tools requirement to 5.9 to match the version defined in https://github.com/segmentio/analytics-swift.git
There was a problem hiding this comment.
why was this stuff removed?
There was a problem hiding this comment.
Remove deeplink setup due to https://firebase.google.com/support/dynamic-links-faq
|
@bsneed could you provide a rough estimate for when could this be merged? |
4 participants
This will bump the minimum deployment level to match Firebase.
Remove deeplink setup due to https://firebase.google.com/support/dynamic-links-faq