Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Node.js runtime from version 18 to version 22 for the Segment Destination Function template, along with updating development dependencies to resolve security vulnerabilities and maintain compatibility with the new Node version.
Changes:
- Node.js runtime upgraded from 18 to 22 across all environments (.nvmrc, package.json, GitHub Actions)
- Development dependencies updated including lint-staged (v13.3.0 → v16.2.7), husky (v8.0.1 → v9.1.7), and other tooling packages
- Pre-commit hook enhanced with Node version verification and NVM setup logic
- GitHub Actions workflows updated to use newer action versions (v4 → v6)
- Documentation cleaned up to remove outdated version references
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .nvmrc | Updates Node version specification from 18 to 22 |
| package.json | Updates Node engine requirement and upgrades all devDependencies to versions compatible with Node 22 |
| README.md | Removes outdated Node version comment and fixes indentation formatting |
| .husky/pre-commit | Adds NVM environment setup and Node 22 version verification with enhanced error messaging |
| .github/workflows/deployDestinationFunction.yml | Updates GitHub Actions checkout and setup-node actions from v4 to v6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
lint-staged v13.3.0withmicromatchsecurity vulnerability (moderate severity)After this PR
lint-stagedupdated to v16.2.7 resolving all security vulnerabilities (0 vulnerabilities)devDependenciesgiven they aren't used by the code in production.eslintrc.jsconfig compatibilitylint-stagedbefore testsReason that prompted this change
Test Plan