-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add McpPlugin protocol and entry_points discovery #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
828f1e7
feat: add McpPlugin protocol and entry_points discovery
bburda f84d24d
fix: address review feedback on plugin system
bburda f29d277
fix: treat empty bearer token env var as unset
bburda deeb7f4
fix: address review feedback - collision check, lifecycle helpers, pr…
bburda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| """Plugin interface for ros2_medkit_mcp. | ||
|
|
||
| Third-party packages can register as plugins via entry_points: | ||
|
|
||
| [project.entry-points."ros2_medkit_mcp.plugins"] | ||
| my_plugin = "my_package.plugin:MyPlugin" | ||
|
|
||
| Plugins must implement the McpPlugin protocol. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import logging | ||
| from importlib.metadata import entry_points | ||
| from typing import Any, Protocol | ||
|
|
||
| from mcp.types import TextContent, Tool | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| PLUGIN_GROUP = "ros2_medkit_mcp.plugins" | ||
|
|
||
|
|
||
| class McpPlugin(Protocol): | ||
| """Interface for MCP server plugins.""" | ||
|
|
||
| @property | ||
| def name(self) -> str: ... | ||
|
|
||
| def list_tools(self) -> list[Tool]: ... | ||
|
|
||
| async def call_tool(self, name: str, arguments: dict[str, Any]) -> list[TextContent]: ... | ||
|
|
||
| async def startup(self) -> None: ... | ||
|
|
||
| async def shutdown(self) -> None: ... | ||
|
|
||
|
|
||
| def discover_plugins() -> list[McpPlugin]: | ||
| """Discover and instantiate plugins registered via entry_points.""" | ||
| plugins: list[McpPlugin] = [] | ||
| for ep in entry_points(group=PLUGIN_GROUP): | ||
| try: | ||
| plugin_cls = ep.load() | ||
| plugin = plugin_cls() | ||
mfaferek93 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if not hasattr(plugin, "name") or not hasattr(plugin, "list_tools"): | ||
| logger.warning("Plugin %s does not implement McpPlugin, skipping", ep.name) | ||
| continue | ||
| logger.info("Discovered plugin: %s (from %s)", plugin.name, ep.value) | ||
| plugins.append(plugin) | ||
| except Exception: | ||
| logger.exception("Failed to load plugin: %s", ep.name) | ||
| return plugins | ||
|
|
||
|
|
||
| async def start_plugins(plugins: list[McpPlugin]) -> list[McpPlugin]: | ||
| """Start plugins, returning only those that started successfully.""" | ||
| started: list[McpPlugin] = [] | ||
| for plugin in plugins: | ||
| try: | ||
| await plugin.startup() | ||
| started.append(plugin) | ||
| logger.info("Plugin started: %s", plugin.name) | ||
| except Exception: | ||
| logger.exception("Failed to start plugin: %s", plugin.name) | ||
| return started | ||
|
|
||
|
|
||
| async def shutdown_plugins(plugins: list[McpPlugin]) -> None: | ||
| """Shut down plugins, logging errors without raising.""" | ||
| for plugin in plugins: | ||
| try: | ||
| await plugin.shutdown() | ||
| except Exception: | ||
| logger.exception("Failed to shutdown plugin: %s", plugin.name) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.