Conversation
✅ Don't forget to add
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 1b6ac5b |
| 🔍 Latest deploy log | https://app.netlify.com/projects/semgrep-docs-prod/deploys/6877b7351310bd0008920275 |
| 😎 Deploy Preview | https://deploy-preview-2243--semgrep-docs-prod.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
| - id: semgrep-ci | ||
| entry: semgrep | ||
| args: ["ci", "--dry-run", "--baseline-commit", "HEAD" "2>/dev/null"] | ||
| args: ["ci", "--dry-run", "--baseline-commit", "HEAD","--quiet"] |
There was a problem hiding this comment.
Both options are mentioned here, so what's the advantage of changing which one is provided?
There was a problem hiding this comment.
@armchairlinguist what is currently in the doc is missing a comma but when you include it in there you still get other errors (see my other comments)
There was a problem hiding this comment.
Yes good catch on the comma, but I don't think there is an issue with the redirect (see previous thread). Both are behaving correctly.
| rev: 'v1.128.0' | ||
| hooks: | ||
| - id: semgrep-verbose | ||
| - id: semgrep-ci |
There was a problem hiding this comment.
I don't think this is correct. semgrep-ci is a named hook that already exists, and this isn't it.
There was a problem hiding this comment.
@armchairlinguist when you run what is currently in the doc, you get the error in the screenshot. It does not complain about that error when you change it from semgrep-verbose to either semgrep or semgrep-ci. However a different error pops up . see below
it only works when I change to --quiet see below
or when you run the pre-commit with 2>/dev/null - see below
Hence why I am making the updates
There was a problem hiding this comment.
There are no errors in this last run. What is the issue you're talking about? The hook "failed" because there are blocking findings.
There was a problem hiding this comment.
The first issue you shared is similar to one that Jon brought up. I still don't entirely understand what's causing that; I don't have that issue in my test repo. Let's discuss it in the internal thread so we don't clutter this one too much.
3 participants
Thanks for improving Semgrep Docs 😀
Please ensure