Draft
Conversation
oscarhearsawho
requested review from
armchairlinguist,
nnayar-r2c and
sebasrevuelta
✅ Don't forget to add
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 2594b0e |
| 🔍 Latest deploy log | https://app.netlify.com/projects/semgrep-docs-prod/deploys/688ce7789523b5000842d4ce |
| 😎 Deploy Preview | https://deploy-preview-2263--semgrep-docs-prod.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Collaborator
|
I think we need to make this change in more places, and provide more context on when and how to set which variables, so I'd advise we don't accept this PR as written but do use it as a foundation to improve here. Thanks for your contributions, Oscar! |
khorne3
reviewed
Aug 4, 2025
| :::note | ||
| - Ensure that you have defined a `SEMGREP_APP_TOKEN` as a credential in Jenkins. | ||
| - The variable SEMGREP_BASELINE_REF must be set to the main branch, in the example: `origin/master`. | ||
| - The variable `SEMGREP_BASELINE_REF` must be set to the main branch, in the example: `origin/master`. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - The variable `SEMGREP_BASELINE_REF` must be set to the main branch, in the example: `origin/master`. | |
| - Ensure that you have defined the variable `SEMGREP_BASELINE_REF` and set its value to the name of the main branch, such as `origin/master`. |
| - Ensure that you have defined a `SEMGREP_APP_TOKEN` as a credential in Jenkins. | ||
| - The variable SEMGREP_BASELINE_REF must be set to the main branch, in the example: `origin/master`. | ||
| - The variable `SEMGREP_BASELINE_REF` must be set to the main branch, in the example: `origin/master`. | ||
| - You may need to set additional variables, depending on your environment configuration, such as; |
Collaborator
There was a problem hiding this comment.
Suggested change
| - You may need to set additional variables, depending on your environment configuration, such as; | |
| - You may need to set additional variables, depending on your environment configuration, such as: |
| - The variable SEMGREP_BASELINE_REF must be set to the main branch, in the example: `origin/master`. | ||
| - The variable `SEMGREP_BASELINE_REF` must be set to the main branch, in the example: `origin/master`. | ||
| - You may need to set additional variables, depending on your environment configuration, such as; | ||
| - `SEMGREP_REPO_NAME` -> An exact, case-sensitive match, to the repository name in Bitbucket |
Collaborator
There was a problem hiding this comment.
Suggested change
| - `SEMGREP_REPO_NAME` -> An exact, case-sensitive match, to the repository name in Bitbucket | |
| - `SEMGREP_REPO_NAME`: The Bitbucket repository name. This value is case sensitive. |
| - The variable `SEMGREP_BASELINE_REF` must be set to the main branch, in the example: `origin/master`. | ||
| - You may need to set additional variables, depending on your environment configuration, such as; | ||
| - `SEMGREP_REPO_NAME` -> An exact, case-sensitive match, to the repository name in Bitbucket | ||
| - `SEMGREP_REPO_URL` -> The web link to your repository (not the `.git` one) |
Collaborator
There was a problem hiding this comment.
Suggested change
| - `SEMGREP_REPO_URL` -> The web link to your repository (not the `.git` one) | |
| - `SEMGREP_REPO_URL`: The web link to your repository (_not_ the `.git` URL). |
| - You may need to set additional variables, depending on your environment configuration, such as; | ||
| - `SEMGREP_REPO_NAME` -> An exact, case-sensitive match, to the repository name in Bitbucket | ||
| - `SEMGREP_REPO_URL` -> The web link to your repository (not the `.git` one) | ||
| - `SEMGREP_COMMIT` -> Specifically for PRs / diff scans, set this to the HEAD commit of the PR |
Collaborator
There was a problem hiding this comment.
Suggested change
| - `SEMGREP_COMMIT` -> Specifically for PRs / diff scans, set this to the HEAD commit of the PR | |
| - `SEMGREP_COMMIT`: The HEAD commit of the pull request. This variable is specifically used for diff-aware scans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result of the Linear FS-2764, we identified that customers using a Jenkins & Bitbucket combo meal may need to include these additional variables in their Jenkins Pipeline:
SEMGREP_REPO_NAMESEMGREP_REPO_URLSEMGREP_COMMITSpecifically the commit one, without this PR comments were failing for the customer, due to a piece of logic we have in
renderer.pythat requires therepo_name,pr_idandcommitto be able to post comments.The definitions I've added (and the location of the addition) might need tweaking, definitely not a final version here.