Clarify IP address allowlisting with TCP port info#2365
Open
kyle-semgrep wants to merge 1 commit intosemgrep:mainfrom
Open
Clarify IP address allowlisting with TCP port info#2365kyle-semgrep wants to merge 1 commit intosemgrep:mainfrom
kyle-semgrep wants to merge 1 commit intosemgrep:mainfrom
Conversation
Added note about TCP port 443 for integrations.
👷 Deploy request for semgrep-docs-prod pending review.Visit the deploys page to approve it
|
| @@ -1,4 +1,4 @@ | |||
| If you are behind a firewall, are using a virtual private network (VPN), or have network restrictions regarding access, you may need to add the following IP addresses to the **ingress** allowlist and **egress** allowlist: | |||
| If you are behind a firewall, are using a virtual private network (VPN), or have network restrictions regarding access, you may need to add the following IP addresses to the **ingress** allowlist and **egress** allowlist. For most integrations, communication will occur over TCP port 443: | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| If you are behind a firewall, are using a virtual private network (VPN), or have network restrictions regarding access, you may need to add the following IP addresses to the **ingress** allowlist and **egress** allowlist. For most integrations, communication will occur over TCP port 443: | |
| If you are behind a firewall, are using a virtual private network (VPN), or have network restrictions regarding access, you may need to add the following IP addresses to the **ingress** allowlist and **egress** allowlist. Communication to and from these IP addresses occurs over TCP port 443 (HTTPS). |
Collaborator
There was a problem hiding this comment.
I think we can be this definitive here, but let's get an SME review to make sure.
In the context of the setup doc (which is one of the two places this is used), there's a following section about Broker that explains it more specifically, which I think is sufficiently clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added note about TCP port 443 for integrations.
Thanks for improving Semgrep Docs 😀
Please ensure