Open
Conversation
Contributor
|
@ConniTheKiwi Cool! Although, I had originally asked for |
Author
|
Ah i seem to have missunderstood, shouldnt be to hard to implement a timer |
Contributor
|
fixes #5 |
-t <time ms> will run only for this set amount of time
Author
|
I believe this is what you requested? |
-m <sub dir name> -m os checks /semc/logger/os
bobbbay
requested changes
Nov 5, 2020
Contributor
bobbbay
left a comment
bobbbay
left a comment
There was a problem hiding this comment.
I've added some generic code reviews - let's see how much this one helps! Cheers 😉
Author
|
Yeh i totally agree with what you have said in this review!, |
Made error messages more appropriate and understandable
Author
|
Ill resolve the switch issue later on as im on mobile currently lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the abilty to parse custom command line args
Added the comand line arg -t
You can now run
./main -t 1000
and it will wait 1000ms (1 second) after each check on the dir