Adding more PT-BR translations and fix existing translations#430
Adding more PT-BR translations and fix existing translations#430JohnTitor merged 7 commits intosemver:gh-pagesfrom
Conversation
|
@LucasHT22 Could you review this when you have time? Thanks in advance! |
LucasHT22
left a comment
LucasHT22
left a comment
There was a problem hiding this comment.
Great translation @jlucfarias ! I left some comments, if you disagree with anything, please, let me know.
lang/pt-BR/spec/v1.0.0-beta.md
Outdated
| uma versão menor foi incrementado, a versão de correção DEVE ser reinicializada | ||
| como 0 (zero). Por exemplo: 1.1.3 -> 2.0.0 e 2.1.7 -> 2.2.0. | ||
|
|
||
| 1. A pre-release version number MAY be denoted by appending an arbitrary |
There was a problem hiding this comment.
From here below it is not translated, since you translated the beginning, I suggest translating the rest too:)
There was a problem hiding this comment.
🤦♂️ sorry for that
lang/pt-BR/spec/v1.0.0.md
Outdated
| - [Silas Ribas Martins](https://github.com/silasrm) | ||
| - [Rogerio Prado de Jesus](https://github.com/rogeriopradoj) | ||
| - [João Lucas Farias](https://github.com/jlucfarias) | ||
|
|
There was a problem hiding this comment.
I don't see any reason to have translation specifications/translators names here, it already exists in https://semver.org/lang/pt-BR/#sobre , would make it confusing when adding new names
There was a problem hiding this comment.
Applies to other files too
|
@jlucfarias Could you check the above review comments? Thanks! |
|
Suggestions applied now, sorry for the late response |
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Thank you both for contributing and reviewing!
3 participants
PR Checklist
specdir.npm run lint.TRANSLATORS.md.This PR supercede #384 and fixes #425