feat(workflow/node-module-cache): support multiple cpu arch #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdelfabbro
force-pushed
the
feat/node-module-cache-cpu-architectures-array
branch
from
b47310c to
1034654
Compare
cdelfabbro
force-pushed
the
feat/node-module-cache-cpu-architectures-array
branch
from
1034654 to
f6f4c7c
Compare
cdelfabbro
force-pushed
the
feat/node-module-cache-cpu-architectures-array
branch
from
f6f4c7c to
4d87da9
Compare
Contributor
usually we put the information in the workflow that it is deprecated (what you did) and communicate to teams that they should migrate (unfortunately you often end up doing it yourself)
There's no easy way to test and automate github workflows modification, it's a bit painful. Let's hope github offer a better experience one day. Some tools allow you to write CI pipeline as code (like https://dagger.io/) so it's much easier to test but it's not as well integrated to Github as a native workflow. |
cdelfabbro
deleted the
feat/node-module-cache-cpu-architectures-array
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this thread, this PR evolves the
node-module-cacheto v2 bringing the support of multiple CPU architecture.Do we have a depreciation process and a test process @jdassonvil?
Edit: I tested it here and the bali database migration is fixed, LGTM.