Add Compression for KafkaSink #2106
Open
+128
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds gzip compression support to the Kafka producer. Users can now configure compression when creating or updating Kafka sinks to reduce network bandwidth and storage requirements.
I chose to only include gzip since other compression formats (snappy, lz4, zstd) require additional libraries to be installed. gzip works out of the box using Erlang's built-in zlib module.
Changes
Backend
Added compression field to KafkaSink schema with enum values: :none, :gzip
Default value is :none (no compression) for backward compatibility
Frontend
Added compression dropdown to Kafka sink configuration form for
NoneandGzipDocumentation
Updated docs/reference/sinks/kafka.mdx with compression configuration details
Tests
I ran the full test suite with the newly-added tests: