reorganization of folders and refactoring#4
Open
khrushv wants to merge 4 commits intosergeyampo:masterfrom
Open
reorganization of folders and refactoring#4khrushv wants to merge 4 commits intosergeyampo:masterfrom
khrushv wants to merge 4 commits intosergeyampo:masterfrom
Conversation
sergeyampo
requested changes
Jun 19, 2020
Comment on lines
+4
to
6
| add_executable(client client.c utils/extract_ip_port_from_string.c utils/opt_arg.c ../lib/check_port.c ../lib/set_sockaddr_in.c) | ||
|
|
||
| target_include_directories(client PUBLIC ./) |
Owner
There was a problem hiding this comment.
In a library directory we have libraries so, why don't you create a directory with check_callbacks and place here check_callbacks.h and build it as a library?
Owner
There was a problem hiding this comment.
Also, you didn't fix last problem, you've included ./ but not ../lib it's unnecessary if you'll make a library, you can just target_link_libraries(client STATIC CheckCallbacks)
Owner
There was a problem hiding this comment.
It's better to explicitly set utils folder and not forcing CMake looking for it!
target_include_directories(client PUBLIC ./ ./utils)
src/server/CMakeLists.txt
Outdated
Comment on lines
+4
to
+6
| add_executable(server server.c utils/opt_arg.c utils/factorial.h utils/factorial.c ../lib/check_port.h ../lib/check_port.c ../lib/set_sockaddr_in.h utils/check_tnum.h utils/check_tnum.c ../lib/set_sockaddr_in.c ../lib/set_sockaddr_in.h ../lib/set_sockaddr_in.c) | ||
| add_executable(server server.c utils/opt_arg.c utils/factorial.c ../lib/check_port.c ../lib/set_sockaddr_in.c) | ||
|
|
||
| target_include_directories(server PUBLIC ./) |
|
|
||
| unsigned int* handle_options(int, char**, struct option[], const int, int (* [])(unsigned int*)); | ||
|
|
||
| int check_tnum(unsigned int* tnum); |
Owner
There was a problem hiding this comment.
In our codestyle we don't write a name of parameter in a header file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.