Some tweaks in libsimpleservo C API#22832
Merged
bors-servo merged 2 commits intoservo:masterfrom Feb 7, 2019
Merged
Conversation
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit a206a80 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Feb 6, 2019
Some tweaks in libsimpleservo C API - Adding logs. - Adding OpenGL support for OSX. - Fixing file reading issue. With this, I can load Servo into a C app (with the C version of libui + andlabs/libui#34). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22832) <!-- Reviewable:end -->
Contributor
|
💔 Test failed - android-mac |
a206a80 to
bfcb8b4
Compare
bfcb8b4 to
6060a36
Compare
Contributor
Author
|
I removed the commit that changes how file content is read. Hopefully we won't need this if this PR lands: #22836 |
Contributor
Author
|
@bors-servo r=jdm |
Contributor
|
📌 Commit 6060a36 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Feb 6, 2019
Some tweaks in libsimpleservo C API - Adding logs. - Adding OpenGL support for OSX. - Fixing file reading issue. With this, I can load Servo into a C app (with the C version of libui + andlabs/libui#405). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22832) <!-- Reviewable:end -->
Contributor
|
💔 Test failed - status-taskcluster |
Member
|
Contributor
|
☔ The latest upstream changes (presumably #22836) made this pull request unmergeable. Please resolve the merge conflicts. |
6060a36 to
1292db6
Compare
Contributor
Author
|
@bors-servo r=jdm |
Contributor
|
📌 Commit 1292db6 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Feb 7, 2019
Some tweaks in libsimpleservo C API - Adding logs. - Adding OpenGL support for OSX. - Fixing file reading issue. With this, I can load Servo into a C app (with the C version of libui + andlabs/libui#405). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22832) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, I can load Servo into a C app (with the C version of libui + andlabs/libui#405).
This change is