Skip to content

chore: update from gh repolint#35

Merged
sethrylan merged 1 commit intomainfrom
update-demo-lint
Feb 24, 2026
Merged

chore: update from gh repolint#35
sethrylan merged 1 commit intomainfrom
update-demo-lint

Conversation

@sethrylan
Copy link
Owner

No description provided.

@sethrylan sethrylan requested a review from Copilot February 24, 2026 03:07
@sethrylan sethrylan self-assigned this Feb 24, 2026
@github-actions
Copy link
Contributor

🎬 Generate a demo GIF for this PR:

gh workflow run demo.yml -R sethrylan/boop -f pr_number=35

Or run from the Actions tab.

@sethrylan sethrylan marked this pull request as ready for review February 24, 2026 03:07
@sethrylan sethrylan merged commit ede757d into main Feb 24, 2026
11 checks passed
@sethrylan sethrylan deleted the update-demo-lint branch February 24, 2026 03:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the demo workflow configuration and documentation from the gh-repolint template repository. The changes significantly improve security by switching from a comment-triggered workflow to a manually-dispatched workflow, which prevents potential "pwn request" attacks where untrusted code could be executed with write permissions.

Changes:

  • Replaced comment-triggered demo generation (/demo command) with manual workflow dispatch requiring write access
  • Enhanced security by checking out PR code by commit SHA instead of branch reference to prevent TOCTOU issues
  • Added comprehensive documentation explaining the security considerations and design decisions
  • Added a hint workflow that automatically posts instructions for generating demos on new PRs

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.repolint.yaml Adds references to new demo-hint workflow and demo-workflow documentation
docs/readme.md Removes old demo documentation (replaced by demo-workflow.md)
docs/demo-workflow.md Adds comprehensive documentation explaining workflow security design and implementation
.github/workflows/demo.yml Switches from issue_comment trigger to workflow_dispatch, improves security by checking out by SHA
.github/workflows/demo-hint.yml Adds new workflow to post helpful demo generation instructions on new PRs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


The demo workflow needs to run on a pull request and write to the same PR branch. This introduces 3 interconnected challenges:

1. **Triggering workflow runs**. By [design](https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow), a commit by GitHub Actions's token cannot trigger a workflow (directly or indirectly) to prevent infinite loops. But most repo's branch protection rules require checks to pass on the latest commit.
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect possessive form. Should be either "repos'" (plural possessive) or "repository's" (singular possessive) instead of "repo's". Since the sentence refers to "most" repositories, "repos'" would be more appropriate.

Suggested change
1. **Triggering workflow runs**. By [design](https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow), a commit by GitHub Actions's token cannot trigger a workflow (directly or indirectly) to prevent infinite loops. But most repo's branch protection rules require checks to pass on the latest commit.
1. **Triggering workflow runs**. By [design](https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow), a commit by GitHub Actions's token cannot trigger a workflow (directly or indirectly) to prevent infinite loops. But most repos' branch protection rules require checks to pass on the latest commit.

Copilot uses AI. Check for mistakes.

The demo workflow needs to run on a pull request and write to the same PR branch. This introduces 3 interconnected challenges:

1. **Triggering workflow runs**. By [design](https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow), a commit by GitHub Actions's token cannot trigger a workflow (directly or indirectly) to prevent infinite loops. But most repo's branch protection rules require checks to pass on the latest commit.
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect possessive form. "GitHub Actions" ends with 's', so the possessive should be "GitHub Actions'" not "GitHub Actions's".

Suggested change
1. **Triggering workflow runs**. By [design](https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow), a commit by GitHub Actions's token cannot trigger a workflow (directly or indirectly) to prevent infinite loops. But most repo's branch protection rules require checks to pass on the latest commit.
1. **Triggering workflow runs**. By [design](https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow), a commit by GitHub Actions' token cannot trigger a workflow (directly or indirectly) to prevent infinite loops. But most repo's branch protection rules require checks to pass on the latest commit.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants