Rename selectors to utilities #572
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mecoccaro
approved these changes
Dec 2, 2021
otech47
reviewed
Dec 13, 2021
Member
otech47
left a comment
otech47
left a comment
There was a problem hiding this comment.
@sofiaromorales maybe the idea here was to not just rename the file but also to split out the functions that begin with select... from the other functions and have those moved to utilities?
Seems like that'd be a good code quality improvement as long as the functions being split up respect what a "selector" is meant to be used for (https://redux.js.org/usage/deriving-data-selectors)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
selectors.jswas refactored toutilities.js