Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,15 @@ public User saveUser(@RequestBody User user) {
@GetMapping("/{id}")
public ResponseTemplateVO getUserWithDepartment(@PathVariable("id") Long userId) {
log.info("Inside getUserWithDepartment of UserController");
return userService.getUserWithDepartment(userId);
try {
return userService.getUserWithDepartment(userId);
} catch (RuntimeException e) {
log.error("Error occurred while acquiring the user: ", e );
ResponseTemplateVO errorResponse = new ResponseTemplateVO();
errorResponse.setDepartment(null);
errorResponse.setUser(null);
return errorResponse;
}
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,20 @@ public ResponseTemplateVO getUserWithDepartment(Long userId) {
ResponseTemplateVO vo = new ResponseTemplateVO();
User user = userRepository.findByUserId(userId);

Department department =
if (user == null) {
log.error("User not found for userId: {}", userId);
}
else{
Department department =
restTemplate.getForObject("http://DEPARTMENT-SERVICE/departments/" + user.getDepartmentId()
,Department.class);

vo.setUser(user);
vo.setDepartment(department);

if (department == null) {
log.error("Department not found for departmentId: {}", user.getDepartmentId());
}
vo.setUser(user);
vo.setDepartment(department);
}

return vo;
}
Expand Down