Open
Conversation
|
|
||
| when: bimanual|bool | ||
|
|
||
| - name: Install right hand store hand icon if bimanual is true or if hand_side="right" |
Collaborator
There was a problem hiding this comment.
Have you updated the tests to test this icon creation (and the script)
| desktop_shortcut_name: Store Right Hand | ||
| comment: "This icon runs a script to put the Hand into a position where it can be stored for transportation. Hand needs to be running." | ||
| folder: "{{ shadow_hand_launcher_folder }}" | ||
| shell_script_file_name: store_right_hand.sh |
Collaborator
devops-shadow
left a comment
devops-shadow
left a comment
There was a problem hiding this comment.
I left some comments mainly for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add new store icon for aurora. Used for packing the hand.
Checklist
Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.
Tests
Documentation