Open
Conversation
niko-holmes
approved these changes
Feb 6, 2025
toliver
requested changes
Feb 6, 2025
| aurora_inventory="ansible/inventory/${aurora_inventory}" | ||
| ansible_flags="${ansible_flags} --ask-become-pass" | ||
| if [[ "${test_machine}" != "true" ]]; then | ||
| ansible_flags="${ansible_flags} --ask-become-pass" |
Contributor
There was a problem hiding this comment.
Why don't we need the become password in the test_machine case?
| fi | ||
| ansible_flags="${ansible_flags} --ask-vault-pass" | ||
| if [[ "${test_machine}" = "true" ]]; then | ||
| ansible_flags="${ansible_flags} --vault-password-file /home/$USER/vault.sh" |
Contributor
There was a problem hiding this comment.
How does the vault.sh file look like? Should we add an exmple file? or a comment describing the contents of such file?
| echo "" | ||
|
|
||
| if [[ "${test_machine}" = "true" ]]; then | ||
| echo $test_password | sudo -S echo "Running on testing machine. Retrieving passwords from ENV..." |
Contributor
There was a problem hiding this comment.
Where does the variable test_password get set? Should we add an example or instructions or a script that calls run-ansible.sh after setting this variable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
add option for password to be read from a vault file (for test machine infrastructure)
Checklist
Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.
Tests
Documentation