port for ff2r, not all abilities working yet, looking forward to help#3
Open
Shacoree wants to merge 1 commit intoshadow93:masterfrom
Open
port for ff2r, not all abilities working yet, looking forward to help#3Shacoree wants to merge 1 commit intoshadow93:masterfrom
Shacoree wants to merge 1 commit intoshadow93:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's using the new ff2r include instead of the legacy ff2 one, plugin is succesfully compiling but not all abilites are working, im not sure if it was working in the first place on the legacy version since i did not play it. Maybe i just put an extra return and continue so that messed it up. Mostly only api changed for FF2R.