Guard against null being returned.#2
Open
Lewiscowles1986 wants to merge 1 commit intoshaggy8871:masterfrom
Open
Guard against null being returned.#2Lewiscowles1986 wants to merge 1 commit intoshaggy8871:masterfrom
Lewiscowles1986 wants to merge 1 commit intoshaggy8871:masterfrom
Conversation
using defaults, enable the same exception as was used for JSON, to be used for YAML move the check for JSON so that undefined types result in error case always (rather than defaulting to JSON decode with 'Unknown' as the outcome from non-js/json file extension Fixes shaggy8871#1
Lewiscowles1986
changed the title
shaggy8871
reviewed
Aug 26, 2019
peter279k
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using defaults, enable the same exception as was used for JSON, to be used for YAML
move the check for JSON so that undefined types result in error case always (rather than defaulting to JSON decode with 'Unknown' as the outcome from non-js/json file extension
Fixes #1