Skip to content

Comments

Rename the cmd binary to be train instead by default#23

Closed
markbates wants to merge 1 commit intoshaoshing:masterfrom
markbates:master
Closed

Rename the cmd binary to be train instead by default#23
markbates wants to merge 1 commit intoshaoshing:masterfrom
markbates:master

Conversation

@markbates
Copy link

By renaming the github.com/shaoshing/train/cmd package to github.com/shaoshing/train/train the binary will be correctly built as train instead of cmd. This is the more idiomatic way to build go binaries, and probably a lot less confusing for people who end up with a cmd binary in the bins directory like I just did. :)

@jboursiquot
Copy link

Any feedback on this and other issues? Would hate to fork this project but it seems that's how peeps get their fixes in.

@logrusorgru
Copy link

I'd prefer cmd/train, see #26
A cmd means executable, following common practice.

@markbates markbates closed this Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants