Rename the cmd binary to be train instead by default#23
Closed
markbates wants to merge 1 commit intoshaoshing:masterfrom
markbates:master
Closed
Rename the cmd binary to be train instead by default#23markbates wants to merge 1 commit intoshaoshing:masterfrom markbates:master
cmd binary to be train instead by default#23markbates wants to merge 1 commit intoshaoshing:masterfrom
markbates:master
Conversation
|
Any feedback on this and other issues? Would hate to fork this project but it seems that's how peeps get their fixes in. |
|
I'd prefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By renaming the
github.com/shaoshing/train/cmdpackage togithub.com/shaoshing/train/trainthe binary will be correctly built astraininstead ofcmd. This is the more idiomatic way to build go binaries, and probably a lot less confusing for people who end up with acmdbinary in thebinsdirectory like I just did. :)