feat: hotfix/v0.1.1 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set ShellUI.Core.IsPackable=false (it's a dependency of ShellUI.Components) - Update release workflow to only publish ShellUI.CLI and ShellUI.Components - Update README to reflect only 2 packages are published - Fixes issue where 3 packages were being published instead of 2
- Set ShellUI.Core.IsPackable=false (it's a dependency of ShellUI.Components) - Update release workflow to only publish ShellUI.CLI and ShellUI.Components - Update README to reflect only 2 packages are published - Fixes issue where 3 packages were being published instead of 2
…into hotfix/v0.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Hotfix: Prevent ShellUI.Core from being published separately
Problem
During the v0.1.0 release, we discovered that 3 NuGet packages were being published instead of the intended 2 packages:
ShellUI.CLI(intended)ShellUI.Components(intended)ShellUI.Core(unintended - should not be published separately)ShellUI.Coreis an internal dependency ofShellUI.Componentsand should not be published as a standalone package.Solution
IsPackable=falseonShellUI.Core.csprojto prevent it from generating a NuGet packageShellUI.CLIandShellUI.ComponentsChanges
src/ShellUI.Core/ShellUI.Core.csproj: AddedIsPackable=false.github/workflows/release.yml: Updated to explicitly publish only the 2 intended packagesREADME.md: RemovedShellUI.Corefrom the package list in versioning documentationImpact
ShellUI.Coredirectly)Testing
IsPackable=falseprevents package generationRelated to: v0.1.0 release
Type: Hotfix
Priority: Medium (prevents unnecessary package publication)