Skip to content

Add overridable parameter#367

Merged
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom
sayan-biswas:override-parameters
Feb 9, 2026
Merged

Add overridable parameter#367
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom
sayan-biswas:override-parameters

Conversation

@sayan-biswas
Copy link
Contributor

@sayan-biswas sayan-biswas commented Jan 21, 2026 •
edited
Loading

Changes

  • Add options to NewParams method to allow overriding certain parameters. This can benefit other projects to import this CLI as library.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Added initialization options for developers to import this CLI as a package and extend.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 21, 2026
@sayan-biswas
Copy link
Contributor Author

sayan-biswas commented Jan 21, 2026

/test release-notes-linter

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026

@sayan-biswas: No presubmit jobs available for shipwright-io/cli@main

Details

In response to this:

/test release-notes-linter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hasanawad94
hasanawad94 approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@hasanawad94 hasanawad94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026
adambkaplan
adambkaplan approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly style nits here - will sleep on this a bit for marking this PR approved.

@adambkaplan
Copy link
Member

adambkaplan commented Jan 27, 2026

I also recommend adding a release note. Developers who import this repo as a library are end users, too!

@sayan-biswas
Add overridable parameter
3da4f12 
# Changes:
- Add options to NewParams method to allow overriding certain parameters. This can benefit other projects to import this CLI as library.

Signed-off-by: Sayan Biswas <sayan-biswas@live.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2026

New changes are detected. LGTM label has been removed.

@adambkaplan
Copy link
Member

adambkaplan commented Feb 9, 2026

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2026
@sayan-biswas sayan-biswas added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 9386c4c into shipwright-io:main Feb 9, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this to Done in Issues Feb 9, 2026
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.19.0 milestone Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@hasanawad94 hasanawad94 hasanawad94 approved these changes

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

@qu1queee qu1queee Awaiting requested review from qu1queee

Assignees

@hasanawad94 hasanawad94

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Issues
Status: Done

Milestone

release-v0.19.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sayan-biswas @adambkaplan @hasanawad94 @SaschaSchwarze0

Comments