Fix revive var-naming lint for build and version packages#370
Fix revive var-naming lint for build and version packages#370IrvingMg wants to merge 1 commit intoshipwright-io:mainfrom
Conversation
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s golangci-lint configuration to suppress revive var-naming findings for the pkg/shp/cmd/build and pkg/shp/cmd/version packages, where the package names intentionally match CLI subcommands.
Changes:
- Added a golangci-lint exclusion rule to ignore
revivevar-naming“conflict with Go standard library package names” findings underpkg/shp/cmd/(build|version)/.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/retest release-notes-linter |
|
@IrvingMg: No presubmit jobs available for shipwright-io/cli@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@SaschaSchwarze0, could you please take a look? |
|
Thanks @IrvingMg, I already augmented your pull request with nolint statements. |
Changes
PR #368 fails due to
revivevar-naminglint errors inpkg/shp/cmd/buildandpkg/shp/cmd/version.Suppress these errors since the package names intentionally match CLI subcommands and do not misuse Go standard library names.
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes