Skip to content

Fix revive var-naming lint for build and version packages#370

Closed
IrvingMg wants to merge 1 commit intoshipwright-io:mainfrom
IrvingMg:fix/golangci-lint-var-naming-exclusion
Closed

Fix revive var-naming lint for build and version packages#370
IrvingMg wants to merge 1 commit intoshipwright-io:mainfrom
IrvingMg:fix/golangci-lint-var-naming-exclusion

Conversation

@IrvingMg
Copy link
Contributor

@IrvingMg IrvingMg commented Feb 14, 2026

Changes

PR #368 fails due to revive var-naming lint errors in pkg/shp/cmd/build and pkg/shp/cmd/version.

Suppress these errors since the package names intentionally match CLI subcommands and do not misuse Go standard library names.

/kind cleanup

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
Copilot AI review requested due to automatic review settings February 14, 2026 19:51
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2026
@openshift-ci openshift-ci bot added release-note kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 14, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qu1queee for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s golangci-lint configuration to suppress revive var-naming findings for the pkg/shp/cmd/build and pkg/shp/cmd/version packages, where the package names intentionally match CLI subcommands.

Changes:

  • Added a golangci-lint exclusion rule to ignore revive var-naming “conflict with Go standard library package names” findings under pkg/shp/cmd/(build|version)/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IrvingMg
Copy link
Contributor Author

/retest release-notes-linter

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2026

@IrvingMg: No presubmit jobs available for shipwright-io/cli@main

Details

In response to this:

/retest release-notes-linter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@IrvingMg
Copy link
Contributor Author

@SaschaSchwarze0, could you please take a look?

@SaschaSchwarze0
Copy link
Member

Thanks @IrvingMg, I already augmented your pull request with nolint statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants