feat: SHIP-0043 BuildRun Executor field#278
Merged
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom Dec 12, 2025
Merged
Conversation
pull-request-size
bot
added
the
size/L
hasanawad94
force-pushed
the
ship-0040-buildrun-executor-field
branch
from
969bedc to
f7040ce
Compare
hasanawad94
changed the title
hasanawad94
force-pushed
the
ship-0040-buildrun-executor-field
branch
from
f7040ce to
39d5f19
Compare
adambkaplan
approved these changes
Nov 24, 2025
Member
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
/approve
This captures the current state of BuildRun status. Added a comment for future reference with respect to supporting non-Tekton executors, which is out of scope for the current proposal.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Explination of the Executor field which was added in shipwright-io/build#1956. Executor field defines the resource responsible for executing a build. Signed-off-by: Hasan Awad <hasan.m.awad94@gmail.com> Co-authored-by: Adam Kaplan <adam.kaplan@redhat.com>
hasanawad94
force-pushed
the
ship-0040-buildrun-executor-field
branch
from
315b859 to
dff5fff
Compare
adambkaplan
reviewed
Dec 8, 2025
Member
There was a problem hiding this comment.
Note - this may get renumbered to SHIP-0044 after merge.
adambkaplan
approved these changes
Dec 12, 2025
Member
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
/lgtm
Approving by lazy consensus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explination of the Executor field which was added in shipwright-io/build#1956. Executor field defines the resource responsible for executing a build.
Changes
Introduces documentation and motivation for the
executorfield of abuildrun.Relevant to shipwright-io/build#1956
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes