test: ErrorIs should support having both err and target be nil#177
Merged
shoenig merged 1 commit intoshoenig:mainfrom Feb 26, 2025
SpikesDivZero:error-is-nil
Merged
test: ErrorIs should support having both err and target be nil#177shoenig merged 1 commit intoshoenig:mainfrom SpikesDivZero:error-is-nil
shoenig merged 1 commit intoshoenig:mainfrom
SpikesDivZero:error-is-nil
Conversation
Go's builtin errors.Is returns true when both target and err are nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go's built-in
errors.Isreturns true when both target and err are nil, but this library marks the test as a failure.I came across this while writing a table-based test, in which I had to work around this by writing:
After this change is applied, the test code can be reduced to a clear statement instead.