Skip to content

Fix deprecation errors with PHP 8.4#134

Open
blmage wants to merge 2 commits intoshoppingflux:masterfrom
blmage:fix/php8.4-deprecation
Open

Fix deprecation errors with PHP 8.4#134
blmage wants to merge 2 commits intoshoppingflux:masterfrom
blmage:fix/php8.4-deprecation

Conversation

@blmage
Copy link
Contributor

@blmage blmage commented Dec 3, 2025

Reason for this PR

Starting with PHP 8.4, implicitly nullable parameter types became deprecated.

What does the PR do

Convert implicitly nullable types to explicit ones.

@mdumoulin
Copy link
Contributor

@blmage Thanks for the PR. We have security concerns in CI due to old dependencies not related to your modifications. I think we should move forward and upgrade some dependencies and version, rather than continue to support such old versions. I proposed another PR to do so : #135

@blmage
Copy link
Contributor Author

blmage commented Jan 6, 2026

That's even better indeed, thanks!

@blmage blmage closed this Jan 6, 2026
@mdumoulin
Copy link
Contributor

That's even better indeed, thanks!

@blmage Note that I did not include your fix in my pull request, but It should make it able to pass the CI now

@blmage blmage reopened this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants