Skip to content

fix: replace bare except clauses with except Exception #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haosenwang1018 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace bare except clauses with except Exception #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/external_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ def _analyze_assets_needed(self, storyboard_data) -> List[str]:
response = self.api_function(prompt, max_tokens=100)[0]
try:
content = response.candidates[0].content.parts[0].text
except:
except Exception:
content = response.choices[0].message.content
elements = [line.strip().lower() for line in content.strip().split("\n") if line.strip()]
return list(dict.fromkeys(elements))[:4]
except:
except Exception:
return []

def _check_cache(self, element: str) -> Optional[str]:
Expand Down Expand Up @@ -162,7 +162,7 @@ def _download_iconfinder(self, element: str) -> Optional[str]:
filepath = self.assets_dir / f"{element}.png"
filepath.write_bytes(img_resp.content)
return str(filepath.absolute())
except:
except Exception:
return None

def _download_iconify(self, element: str) -> Optional[str]:
Expand All @@ -178,7 +178,7 @@ def _download_iconify(self, element: str) -> Optional[str]:
filepath = self.assets_dir / f"{element}.svg"
filepath.write_text(svg_resp.text, encoding="utf-8")
return str(filepath.absolute())
except:
except Exception:
return None

def _enhance_animations(self, animations: List[str], assets: Dict[str, str]) -> List[str]:
Expand Down