Skip to content

Toptal-specific code (html_safe) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shurikp wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Toptal-specific code (html_safe) #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f038bf8
Fix represneted attribtues' errors moving
shurikp Aug 24, 2022
4a0f5e3
Copy error from represented attribute, if not given explicitly, and h…
shurikp Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/active_data/model/representation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,15 @@ def emerge_represented_attributes_errors!

if ActiveModel.version >= Gem::Version.new('6.1.0')
def move_errors(from, to)
errors.each do |error|
next unless error.attribute == from
errors.where(from).each do |error|
options = error.options
# If we generate message for built-in validation, we don't want to later escape it in our monkey-patch
options = options.merge(message: error.message.html_safe) unless options.key?(:message)

errors.add(to, error.type, message: error.message)
errors.delete(error.attribute, error.type)
errors.add(to, error.type, **options)
end

errors.delete(from)
end
else # up to 6.0.x
def move_errors(from, to)
Expand Down