Feat/refresh icon #216
Open
Feat/refresh icon #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylembachar
reviewed
Nov 7, 2024
ylembachar
reviewed
Nov 8, 2024
Collaborator
ylembachar
left a comment
ylembachar
left a comment
There was a problem hiding this comment.
Could you please also add a unit test to cover this feature so that we make sure that websocket events are updating the card and that it progresses with the user's clock? There is an example using time under the slot progression test that you could use - thanks: https://github.com/shutter-network/shutter-explorer/blob/main/frontend/cypress/components/SlotProgression.cy.tsx#L15
ylembachar
reviewed
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #87