Event carries binlog filename and offset.

[michaelschiff]

Simplifies logic for EventListeners that care about checkpointing progress

[shyiko]

I'm sorry, but signatures of public constructors/methods are not allowed to change / offset++ is incorrect.

[michaelschiff]

Understood. Do you have any thoughts on the intent of the change (exposing the binlog filename and offset on the event itself)? I modified the constructor to keep the new fields effectively final, but I can expose this information without changing the existing public API.

[shyiko]

To be honest, I'm not sure. So far, I've tried to keep Event|s close to their actual representaion in the binlog (one of the reasons why Event::getHeader() content is not part of the Event itself). I understand why it would be helpful to have both binlogFilename and the already present postion in the Event itself but considering that this piece of information is already available to the user either directly or inderectly I'm more inclined to reevaluate the addition in 1.0.0.

[michaelschiff]

Fair enough, I'm happy to revisit it then. Accessing this information indirectly through the client certainly works the way things are currently implemented. The only thing that would force this change from nice-to-have to correctness requirement would be if listener notification was made asynchronous. Barring that maybe the more appropriate change would be an extra line in the documentation/README describing how listeners can track position.