Skip to content

Conversation

@nud
Copy link

@nud nud commented Oct 16, 2013

The basic concept of this backend is to forward TFTP queries "as is" to an
HTTP server, as a simple way to allow dynamic files generated on the fly for
each TFTP request.

RRQ are forwarded as GET requests.
WRQ are forwarded as PUT requests.

@shylent
Copy link
Owner

shylent commented Oct 20, 2013

To be honest, I am very strongly against using synchronous network operations (HTTP requests) in the context of an asynchronous library, especially considering the fact, that there is a solid HTTP implementation in twisted itself.

I would replace the use of "requests" (and the uncalled for introduction of external dependency) with the use of twisted.http.client.

Perhaps, I'll find some time in the following week or two to do it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants