Don't send more than one ACK to the last DATA packet when writing. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The write session needs to remain open for a short while so that ACKs can be returned if a duplicate DATA packet is received. However, when the last packet is received the code will always send additional ACKs because there is no next DATA packet to cancel the ScheduledCall the handles ACK retransmission. So, in the special case of the last DATA packet, send an ACK once, but never again. The timeout needs to remain to keep the session active in case the ACK packet gets lost and the remote system re-sends the last DATA packet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The write session needs to remain open for a short while so that ACKs
can be returned if a duplicate DATA packet is received. However, when
the last packet is received the code will always send additional ACKs
because there is no next DATA packet to cancel the ScheduledCall the
handles ACK retransmission. So, in the special case of the last DATA
packet, send an ACK once, but never again. The timeout needs to remain
to keep the session active in case the ACK packet gets lost and the
remote system re-sends the last DATA packet.