Add creation and resolution of DIDs using method 1#46
Draft
andrewwhitehead wants to merge 3 commits intosicpa-dlab:mainfrom
Draft
Add creation and resolution of DIDs using method 1#46andrewwhitehead wants to merge 3 commits intosicpa-dlab:mainfrom
andrewwhitehead wants to merge 3 commits intosicpa-dlab:mainfrom
Conversation
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
0ff69ce to
ff6f6de
Compare
|
@andrewwhitehead — should this be closed, or moved forward? If it is valuable, can it be taken over by someone else — merged onto a branch and evolved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in draft until I can do some more testing. The method-1 test vectors are from aries-framework-javascript, and do not pass strict validation in pydid (but invalid documents are still allowed).
resolve_peer_did_basismethod returning aResolvedBasisinstance, making it easier to pull out the relevant keyssplit_peer_didmethod which can be used to check the inception method before attempting resolutionBaseKey.to_base58method as well asBaseKey.from_verification_method@dbluhm @swcurran