shorten python case names, handle if payload has an 'id' field. #51
Draft
Jsyro wants to merge 2 commits intosicpa-dlab:mainfrom
Draft
shorten python case names, handle if payload has an 'id' field. #51Jsyro wants to merge 2 commits intosicpa-dlab:mainfrom
Jsyro wants to merge 2 commits intosicpa-dlab:mainfrom
Conversation
if this is not done, service_endpoint is infered, and also included as a kwarg, causing a conflict in the decode_service method and an exception is raised. Signed-off-by: Jason Syrotuck <jasyrotuck@gmail.com>
Signed-off-by: Jason Syrotuck <jasyrotuck@gmail.com>
Jsyro
commented
Jul 6, 2023
Contributor
Author
Jsyro
left a comment
Jsyro
left a comment
There was a problem hiding this comment.
Changing to list has caused a few other small issues, I will resolve those and push changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
service_endpointis not abbreviated properly as it looking forserviceEndpointinstead, soserivce_endpointgets added toextraand when it is decoded, this constructor gets passes multiple parameters with the name 1service_endpoint`.peer-did-python/peerdid/core/peer_did_helper.py
Line 135 in 6bcfc4c
This change would abbreviate python and javascript naming conventions, which would be expanded to the pythonicly named class attributes on service_decode.
A simliar conflict exists if the service entry has an 'id' field, so if one exists, use it, otherwise generate one.