Skip to content

Conversation

@phoenix-ru
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This updates Node version used inside project to 24 so that NPM also gets updated to 11.5.1+ to support Trusted Publishing.

As jsonwebtoken is not compatible with Node 24, it got replaced by jose.

The error with jsonwebtoken and Node 24 was (see similar report):

 ERROR  [uncaughtException] includes.bind is not a function                                                                                                                                                                                                        17:13:44

    at .nuxt/dev/index.mjs:2805:34
    at ModuleJob.run (node:internal/modules/esm/module_job:413:25)
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:660:26)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:101:5)
 ERROR  [request error] [unhandled] [GET] http://localhost:3000/                                                                                                                                                                                                   17:13:58


β„Ή Error: Cannot access 'renderer$1' before initialization

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 6, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@sidebase/nuxt-auth@1082

commit: 874a4a6

Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider reducing changes to a minimum.

Besides this: Could not do a propper review - but based on your decision of minimizing changes it's probably good to do the full review in the next iteration only.

BracketJohn
BracketJohn previously approved these changes Feb 6, 2026
Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - did you functionally verify that the playground is still in tact? If so, please document it as a comment here and then this is good to merge.

@phoenix-ru
Copy link
Collaborator Author

Looks good - did you functionally verify that the playground is still in tact? If so, please document it as a comment here and then this is good to merge.

Yes, I did when working on it. There's a TypeScript problem due to me haphazardly updating Nuxt, fixing it rn

Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we caught that.

@phoenix-ru phoenix-ru merged commit 522f41d into main Feb 6, 2026
7 checks passed
@phoenix-ru phoenix-ru deleted the chore/bump-node-version-and-replace-jsonwebtoken branch February 6, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants