-
-
Notifications
You must be signed in to change notification settings - Fork 189
chore: bump Node to 24 and replace jsonwebtoken #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump Node to 24 and replace jsonwebtoken #1082
Conversation
commit: |
BracketJohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider reducing changes to a minimum.
Besides this: Could not do a propper review - but based on your decision of minimizing changes it's probably good to do the full review in the next iteration only.
BracketJohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - did you functionally verify that the playground is still in tact? If so, please document it as a comment here and then this is good to merge.
Yes, I did when working on it. There's a TypeScript problem due to me haphazardly updating Nuxt, fixing it rn |
BracketJohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad we caught that.
π Linked issue
β Type of change
π Description
This updates Node version used inside project to 24 so that NPM also gets updated to 11.5.1+ to support Trusted Publishing.
As
jsonwebtokenis not compatible with Node 24, it got replaced byjose.The error with
jsonwebtokenand Node 24 was (see similar report):π Checklist