Skip to content

Conversation

@akashsonune
Copy link
Member

@akashsonune akashsonune commented Jan 14, 2026

BREAKING CHANGE: The SiChartsNgModule is removed. Use separate entry points available for each component.

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


@akashsonune akashsonune added this to the 51.0.0 milestone Jan 14, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @akashsonune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the @siemens/charts-ng library by eliminating the deprecated SiChartsNgModule. This strategic removal enforces a more modular import pattern, requiring consumers to import individual chart components directly from their dedicated entry points. The primary goal of this change is to enhance application performance by reducing bundle sizes and improving tree-shaking efficiency.

Highlights

  • Removal of Deprecated Module: The SiChartsNgModule has been completely removed, as it was previously marked as deprecated and scheduled for removal in v51.
  • Breaking Change: This change introduces a breaking change. Applications that previously imported SiChartsNgModule will now need to update their import statements.
  • Mandatory Individual Component Imports: Consumers are now required to import individual chart components directly from their specific entry points (e.g., @siemens/charts-ng/cartesian). This approach avoids unnecessary module imports and contributes to a reduced application bundle size.
  • Documentation Update: The README.md file has been updated to reflect the new import strategy, guiding users on how to correctly import components.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great refactoring that removes the deprecated SiChartsNgModule and enforces the use of secondary entry points for better tree-shaking. The changes are consistent across the API documentation, README, and source code. I have one suggestion regarding the main public-api.ts to improve clarity for developers using the library.

Comment on lines +5 to +6
/** */
export const NOTHING = 'nothing';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Exporting a NOTHING constant from the main entry point can be confusing for developers, as its purpose isn't immediately clear. To improve clarity, consider replacing this with a descriptive comment explaining that this entry point is intentionally empty and that developers should use the secondary entry points. If an export is strictly necessary for the build process, an explanatory comment should accompany it.

Suggested change
/** */
export const NOTHING = 'nothing';
/**
* The main entry point `@siemens/charts-ng` is intentionally left empty.
* Please use secondary entry points for individual components, for example:
* `import { SiChartCartesianComponent } from '@siemens/charts-ng/cartesian';`
*
* This approach promotes smaller bundle sizes by allowing you to import only what you need.
*/

BREAKING CHANGE: The `SiChartsNgModule` is removed. Use separate entry points available for each component.
@akashsonune akashsonune force-pushed the refactor/remove-deprecated-si-charts-ng-module branch from 33720c4 to c7079a7 Compare January 14, 2026 10:36
@github-actions
Copy link

Code Coverage

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants