-
Notifications
You must be signed in to change notification settings - Fork 13
refactor(angular): drop attr from aria binding #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Angular now supports direct aria attribute binding. See https://angular.dev/guide/templates/binding#aria-attributes
Summary of ChangesHello @chintankavathia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive refactoring of how ARIA attributes are bound within Angular templates and host directives. By adopting the direct Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is a great refactoring that modernizes the codebase by adopting Angular's direct ARIA attribute binding syntax. The changes are applied consistently and correctly across a large number of files, which will improve readability and maintainability. I've reviewed all the changes and found no issues. Excellent work!
|
Documentation. Coverage Reports: |
Angular now supports direct aria attribute binding. See https://angular.dev/guide/templates/binding#aria-attributes