refactor: remove simpl type alias #1332
Conversation
akashsonune
commented
Jan 19, 2026
akashsonune
commented
- I confirm that this MR follows the contribution guidelines.
Summary of ChangesHello @akashsonune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a refactoring to remove various Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a refactoring that removes several Simpl... type aliases, which is a good cleanup of legacy code. The changes are straightforward and correct. However, I've noticed that the corresponding migration schematic mappings for some of the removed aliases still exist. This could lead to issues with the migration schematics. I've left comments on the relevant files pointing out these inconsistencies.
| }) | ||
| export class SiChartsNgModule {} | ||
|
|
||
| export { SiChartsNgModule as SimplChartsNgModule }; |
There was a problem hiding this comment.
Removing this alias is a good cleanup. However, the migration schematic mapping for SimplChartsNgModule still exists in projects/element-ng/schematics/ts-import-to-siemens-migration/mappings/charts-ng-mappings.ts. Since this alias is being removed, the mapping is now likely obsolete and should probably be removed as well to avoid issues with the migration schematic.
| }) | ||
| export class SiMapsNgModule {} | ||
|
|
||
| export { SiMapsNgModule as SimplMapsNgModule }; |
There was a problem hiding this comment.
Similar to other removals in this PR, while removing this alias is correct, the corresponding entry for SimplMapsNgModule in projects/element-ng/schematics/ts-import-to-siemens-migration/mappings/maps-ng-mappings.ts seems to have been missed. Please consider removing it to keep the migration schematics consistent.
| }) | ||
| export class SiNativeChartsNgModule {} | ||
|
|
||
| export { SiNativeChartsNgModule as SimplNativeChartsNgModule }; |
There was a problem hiding this comment.
The removal of the SimplNativeChartsNgModule alias is a good step. However, a corresponding entry still exists in projects/element-ng/schematics/ts-import-to-siemens-migration/mappings/native-charts-ng-mappings.ts. This should likely be removed to prevent the migration schematic from referencing a non-existent export.
akashsonune
force-pushed
the
refactor/remove-simpl-type-alias
branch
from
d5b9752 to
11cba5a
Compare
|
|
|
Documentation. Coverage Reports: |
akashsonune
requested review from
a team,
chintankavathia and
dr-itz
as code owners
|
@spike-rabbit can we just remove them for 49 or first mark them deprecated? since this was only meant for the compatibility for simpl element |
akashsonune
added
the
breaking-changes
|
They are not causing any harm. Let's just go here with the normal deprecation first. |
|
ok lets park this one for v51 |
