Skip to content

refactor(vertical-navbar): use native CSS animations for si-navbar-ve… #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
spliffone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(vertical-navbar): use native CSS animations for si-navbar-ve… #1350

spliffone wants to merge 1 commit into from

Conversation

@spliffone
Copy link
Member

@spliffone spliffone commented Jan 21, 2026 •
edited
Loading

…rtical-header

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.

@spliffone spliffone requested a review from a team as a code owner January 21, 2026 13:59
spike-rabbit
spike-rabbit requested changes Jan 21, 2026
View reviewed changes
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check whether it might be easier to just use animate.enter / leave instead of always having those elements in the DOM?

@spliffone spliffone force-pushed the refactor/vertical-vabar-header-use-css-transition branch from a19beeb to 6c3d17c Compare January 21, 2026 15:33
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

Documentation.
Examples.
Playwright report.

Coverage Reports:

@spliffone spliffone force-pushed the refactor/vertical-vabar-header-use-css-transition branch 2 times, most recently from adff25e to 7b8a735 Compare January 24, 2026 11:10
@spliffone spliffone force-pushed the refactor/vertical-vabar-header-use-css-transition branch from 7b8a735 to 7a6798f Compare January 24, 2026 16:28
@github-actions
Copy link

github-actions bot commented Jan 24, 2026

Code Coverage

@spliffone
Copy link
Member Author

spliffone commented Jan 25, 2026

Did you check whether it might be easier to just use animate.enter / leave instead of always having those elements in the DOM?

@spike-rabbit we use now animate.leave like you proposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spike-rabbit spike-rabbit spike-rabbit requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spliffone @spike-rabbit