Sourcery refactored ascii-encoding branch

[sourcery-ai]

Branch ascii-encoding refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the ascii-encoding branch, then run:

git fetch origin sourcery/ascii-encoding
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Lines 28-42 refactored with the following changes:

• If else clause is always executed move code to same level as loop (useless-else-on-loop)
• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Function Window.addForm refactored with the following changes:

• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.71%.

Quality metrics	Before	After	Change
Complexity	0.73 ⭐	0.26 ⭐	-0.47 👍
Method Length	22.55 ⭐	22.38 ⭐	-0.17 👍
Working memory	5.91 ⭐	5.88 ⭐	-0.03 👍
Quality	88.49% ⭐	89.20% ⭐	0.71% 👍

Other metrics	Before	After	Change
Lines	131	118	-13

Changed files	Quality Before	Quality After	Quality Change
console.py	74.40% 🙂	77.67% ⭐	3.27% 👍
gui.py	90.90% ⭐	90.91% ⭐	0.01% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gui.py	FieldLabel.__init__	0 ⭐	36 ⭐	10 😞	78.76% ⭐	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!